Re: [PATCH 1/2] cgroup: revise how we re-populate root directory

[Li Zefan]

>> @@ -1284,6 +1296,7 @@ static int cgroup_remount(struct super_block *sb, int *flags, char *data)
>>        struct cgroupfs_root *root = sb->s_fs_info;
>>        struct cgroup *cgrp = &root->top_cgroup;
>>        struct cgroup_sb_opts opts;
>> +       unsigned long added_bits, removed_bits;
>>
>>        mutex_lock(&cgrp->dentry->d_inode->i_mutex);
>>        mutex_lock(&cgroup_mutex);
>> @@ -1294,6 +1307,9 @@ static int cgroup_remount(struct super_block *sb, int *flags, char *data)
>>        if (ret)
>>                goto out_unlock;
>>
>> +       added_bits = opts.subsys_bits & ~root->subsys_bits;
>> +       removed_bits = root->subsys_bits & ~opts.subsys_bits;
>> +
> 
> Should it be the followingïï
>           added_bits = opts.subsys_bits & ~root->actual_subsys_bits;
>           removed_bits = root->actual_subsys_bits & ~opts.subsys_bits;
> 

subsys_bits and actual_subsys_bits differ during cgroup_mount() only,
and in other places they are replaceable with each other.

Thanks for looking into this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/