Re: [patch] nfsd: oopses in cache_parse()

[Dan Carpenter]

On Mon, Jan 16, 2012 at 10:50:31AM -0500, J. Bruce Fields wrote:
> On Mon, Jan 16, 2012 at 02:52:58PM +0300, Dan Carpenter wrote:
> > We fixed expkey_parse() in b2ea70afad "nfsd: Fix oops when parsing a
> > 0 length export" but there are other cache_parse() implimentations
> > which have the same issue.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > Since half of the implimentations get this wrong, maybe we should
> > just check for this in cache_do_downcall().  Is there ever a valid
> > reason to pass a zero length string to cache_parse()?
> 
> I don't think so, no.  Checking in cache_do_downcall() sounds like a
> good idea.

Yeah.  I checked and none of the cache_parse() implementations do
anything with a zero length string.  Ignore that patch, I'll send
another.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature