[PATCH] x86: uninitialized spinlocks in tlb_uv.c

From: Cliff Wickman
Date: Wed Jan 18 2012 - 10:40:22 EST


From: Cliff Wickman <cpw@xxxxxxx>

Initialize two spinlocks in tlb_uv.c.

The lack of explicit initialization seems to be functionally harmless (the
locks are initialized to 0's), but it is diagnosed when these are turned on:
CONFIG_DEBUG_SPINLOCK=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_LOCK_ALLOC=y
CONFIG_LOCKDEP=y

Signed-off-by: Cliff Wickman <cpw@xxxxxxx>
---
arch/x86/platform/uv/tlb_uv.c | 2 ++
1 file changed, 2 insertions(+)

Index: 120113.linux-3.2.1/arch/x86/platform/uv/tlb_uv.c
===================================================================
--- 120113.linux-3.2.1.orig/arch/x86/platform/uv/tlb_uv.c
+++ 120113.linux-3.2.1/arch/x86/platform/uv/tlb_uv.c
@@ -1851,6 +1851,8 @@ static void __init init_per_cpu_tunables
bcp->cong_reps = congested_reps;
bcp->cong_period = congested_period;
bcp->clocks_per_100_usec = usec_2_cycles(100);
+ spin_lock_init(&bcp->queue_lock);
+ spin_lock_init(&bcp->uvhub_lock);
}
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/