Re: [patch 2/2] mm: memcg: hierarchical soft limit reclaim

From: Sha
Date: Thu Jan 19 2012 - 01:38:44 EST


On 01/18/2012 11:27 PM, Michal Hocko wrote:
On Wed 18-01-12 19:25:27, Sha wrote:
[...]
Er... I'm even more confused: mem_cgroup_soft_limit_reclaim indeed
choses the biggest soft-limit excessor first, but in the succeeding reclaim
mem_cgroup_hierarchical_reclaim just selects a child cgroup by css_id
mem_cgroup_soft_limit_reclaim picks up the hierarchy root (most
excessing one) and mem_cgroup_hierarchical_reclaim reclaims from that
subtree). It doesn't care who exceeds the soft limit under that
hierarchy it just tries to push the root under its limit as much as it
can. This is what Johannes tried to explain in the other email in the
thred.
yeah, I finally twig what he meant... I'm not quite familiar with this part.
Thanks a lot for the explanation. :-)

Sha
which has nothing to do with soft limit (see mem_cgroup_select_victim).
IMHO, it's not a genuine hierarchical reclaim.
It is hierarchical because it iterates over hierarchy it is not and
never was recursively soft-hierarchical...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/