Re: [PATCH 2/5] SUNRPC: create unix gid cache per network namespace
From: J. Bruce Fields
Date: Thu Jan 19 2012 - 11:24:38 EST
On Thu, Jan 19, 2012 at 06:49:14PM +0400, Stanislav Kinsbursky wrote:
> This patch makes unix_gid_cache cache detail allocated and registered per
> network namespace context.
> Thus with this patch unix_gid_cache contents for network namespace "X" are
> controlled from proc file system mount for the same network namespace "X".
I'm confused--this seems half-done. I see that you're creating the gid
caches dynamically, but there's still this static definition:
> struct cache_detail unix_gid_cache = {
> .owner = THIS_MODULE,
> .hash_size = GID_HASHMAX,
> - .hash_table = gid_table,
> .name = "auth.unix.gid",
> .cache_put = unix_gid_put,
> .cache_upcall = unix_gid_upcall,
And it looks like unix_gid_lookup is still using this static
unix_gid_cache. Maybe I'm missing something....
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/