Re: [PATCH] fs, proc: Introduce /proc/<pid>/task/<tid>/childrenentry v7

[Oleg Nesterov]

On 01/19, Cyrill Gorcunov wrote:
>
> On Thu, Jan 19, 2012 at 07:51:12PM +0400, Cyrill Gorcunov wrote:
> > If it's needed I can wrap all this with CONFIG_CHECKPOINT_RESTORE, should I?
> >
> > ---
>
> Oleg, if only I'm not missing something obvious you meant handling like below?

Yes, but...

> +struct proc_pid_children_iter {
> +	struct pid_namespace *pid_ns;
> +	struct pid *parent_pid;
> +};

you forgot to remove this definition.

> +static int children_seq_show(struct seq_file *seq, void *v)
> +{
> +	struct inode *inode = seq->private;
> +	unsigned long pid;
> +
> +	pid = (unsigned long)pid_nr_ns(v, inode->i_sb->s_fs_info);
> +	return seq_printf(seq, " %lu", pid);
> +}

just noticed... why unsigned long and %lu? afaics pid_t/%d should work
without any typecasts.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/