Re: [RFC] syscalls, x86: Add __NR_kcmp syscall

From: Cyrill Gorcunov
Date: Fri Jan 20 2012 - 04:02:55 EST


On Fri, Jan 20, 2012 at 12:40:08PM +0400, Cyrill Gorcunov wrote:
...
> +
> +static __init int kcmp_cookie_init(void)
> +{
> + int i, j;
> +
> + for (i = 0; i < KCMP_TYPES; i++) {
> + for (j = 0; j < 2; j++) {
> + get_random_bytes(&cookies[i][j], sizeof(cookies[i][j]));
> +
> + if (cookies[i][j])
> + continue;
> +
> + /*
> + * This is impossible case but just to be sure.
> + */
> + cookies_valid = false;
> + WARN_ONCE(1, "Can't get random bytes for k-pointers\n");
> + }
> + }
> +
> + cookies_valid = true;

darn, this string of course should be on top,
i'll update don't complain on this nit.

> +
> + return 0;
> +}

Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/