Re: [PATCH v2] serial: trivial checkpatch fixes in drivers/tty/serial/8250.c

[Jiri Slaby]

On 01/20/2012 01:24 AM, Simon Glass wrote:
> @@ -2006,8 +2010,8 @@ static int serial8250_startup(struct uart_port *port)
>  	 */
>  	if (!(up->port.flags & UPF_BUGGY_UART) &&
>  	    (serial_inp(up, UART_LSR) == 0xff)) {
> -		printk_ratelimited(KERN_INFO "ttyS%d: LSR safety check engaged!\n",
> -				   serial_index(&up->port));
> +		pr_info_ratelimited(

FWIW I hate these macros. Beginners ask what the heck stands "pr" for?

> @@ -3053,8 +3063,8 @@ static int __devinit serial8250_probe(struct platform_device *dev)
>  		port.irqflags		|= irqflag;
>  		ret = serial8250_register_port(&port);
>  		if (ret < 0) {
> -			dev_err(&dev->dev, "unable to register port at index %d "
> -				"(IO%lx MEM%llx IRQ%d): %d\n", i,
> +			dev_err(&dev->dev, "unable to register port at "
> +				"index %d (IO%lx MEM%llx IRQ%d): %d\n", i,

Nack to this. It makes grepping harder.

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/