Re: [PATCH 2/2] cgroup: add xattr support

[Lennart Poettering]

On Wed, 18.01.12 18:40, Tejun Heo (tj@xxxxxxxxxx) wrote:

> 
> On Wed, Jan 18, 2012 at 06:20:05PM -0800, Tejun Heo wrote:
> > Hello, Lennart, Li.
> > 
> > Two things.
> > 
> > * Probably I'm missing something but isn't the systemd cgroup
> >   hierarchy already managed by systemd?  If so, I don't see how
> >   managing tmpfs on the side would noticeably make things more
> >   fragile.  It would take a bit more care after, for example, restart
> >   but it shouldn't be too complex, no?
> > 
> > * FS attributes already being used for userland information seems like
> >   a good argument, but we shouldn't add separate specialized xattr
> >   implementation to different pseudo filesystems.  For it to be
> >   acceptable, it should be a libfs thing easily applicable to any
> >   pseudo FS and definitely shouldn't be using kmem for storage.
> 
> Also note that tmpfs also implies size limit.  We definitely need some
> form of control over the amount of memory xattr may consume.

Good point. But then again we don't even have anything resembling for
tmpfs either, where it would be much more important... :-(

Given that cgroupfs is probably mostly read-only for normal users, the
requirement for quotas on it is probably much less important than for tmpfs
though.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/