Re: [PATCH 1/3] net: fix socket memcg build with !CONFIG_NET

[Glauber Costa]

On 01/20/2012 11:14 PM, David Miller wrote:
> From: Glauber Costa<glommer@xxxxxxxxxxxxx>
> Date: Fri, 20 Jan 2012 18:57:14 +0400
>
> > There is still a build bug with the sock memcg code, that triggers
> > with !CONFIG_NET, that survived my series of randconfig builds.
> >
> > Signed-off-by: Glauber Costa<glommer@xxxxxxxxxxxxx>
> > Reported-by: Randy Dunlap<rdunlap@xxxxxxxxxxxx>
> > CC: Hiroyouki Kamezawa<kamezawa.hiroyu@xxxxxxxxxxxxxx>
>
> Why are you undoing the static branch optimization?  That was a one of
> the things that made me agree to even putting this code in.
>
> Find a way to fix this without removing the static branch.
Dave,

I am not removing the static branch. This is just a macro, that expands 
to the static branch when the options are in place, and to 0 if they are 
not.

if (0) { } is certainly be removed to the compiler, so the code is out
anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/