Re: [PATCH 01/17] blkcg: make CONFIG_BLK_CGROUP bool

[Tejun Heo]

Hello,

On Mon, Jan 23, 2012 at 10:00:51AM -0500, Vivek Goyal wrote:
> On Sat, Jan 21, 2012 at 07:25:09PM -0800, Tejun Heo wrote:
> > Block cgroup core can be built as module; however, it isn't too useful
> > as blk-throttle can only be built-in and cfq-iosched is usually the
> > default built-in scheduler.  Scheduled blkcg cleanup requires calling
> > into blkcg from block core.  To simplify that, disallow building blkcg
> > as module by making CONFIG_BLK_CGROUP bool.
> > 
> > If building blkcg core as module really matters, which I doubt, we can
> > revisit it after blkcg API cleanup.
> 
> I think not allowing compiling blk-cgroup as module is a good thing.

Sure, it's nice.  It just is mostly pointless at this point and
hinders API cleanup.  As written above, if this really matters, let's
add it back after cleanup is complete.

> >  config IOSCHED_CFQ
> >  	tristate "CFQ I/O scheduler"
> > -	# If BLK_CGROUP is a module, CFQ has to be built as module.
> > -	depends on (BLK_CGROUP=m && m) || !BLK_CGROUP || BLK_CGROUP=y
> > +	depends on BLK_CGROUP
> 
> You don't need above dependency now. Otherwise if BLK_CGROUP=n then one
> can't use CFQ. We just want cfq group scheduling to be dependent on
> BLK_CGROUP.

Ooh, right, will drop the line.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/