Re: [PATCH v2 2/2] regulator: add device tree support for max8997

[Karol Lewandowski]

On 12.01.2012 08:35, Thomas Abraham wrote:

Hi!

> Add device tree based discovery support for max8997.

> +static int max8997_pmic_dt_parse_pdata(struct max8997_dev *iodev,
> +					struct max8997_platform_data *pdata)
> +{
...
> +	pdata->regulators = rdata;
> +	for_each_child_of_node(regulators_np, reg_np) {
> +		for (i = 0; i<  ARRAY_SIZE(regulators); i++)
> +			if (!of_node_cmp(reg_np->name, regulators[i].name))
> +				break;

If I read your patch correctly it would impossible to configure 
following outputs when pmic is instantiated from DT:

    enum max8998_regulators {
    ...
 1    MAX8997_EN32KHZ_AP,
 2    MAX8997_EN32KHZ_CP,
 3    MAX8997_CHARGER_CV,
 4    MAX8997_CHARGER_TOPOFF, /* MBCCTRL5 */

This is due to use of embedded spaces in regulator names (which are used 
in comparision).

This can be fixed with trivial patch[1].

What bothers me more, are following regulators:

      MAX8997_EN32KHZ_AP,
      MAX8997_EN32KHZ_CP,
      MAX8997_ENVICHG,
      MAX8997_ESAFEOUT1,
      MAX8997_ESAFEOUT2,

Aren't these fixed? i.e. - is it really needed to configure these either 
by platform data or DT at all?


[1]

From 5cfba526210bc596c7d14e33fea93648baa0a227 Mon Sep 17 00:00:00 2001
From: Karol Lewandowski <k.lewandowsk@xxxxxxxxxxx>
Date: Mon, 23 Jan 2012 17:20:25 +0100
Subject: [PATCH] max8997: Avoid spaces in regulator names

max8997-pmic instantiated from device tree uses names,
not numerical ids to distinguish between outputs.

Use names without spaces to make it possible to specify
parameters for said regulators in DTS.

Signed-off-by: Karol Lewandowski <k.lewandowsk@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
---
 drivers/regulator/max8997.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c
index 053d0b7..4b572eb 100644
--- a/drivers/regulator/max8997.c
+++ b/drivers/regulator/max8997.c
@@ -910,13 +910,13 @@ static struct regulator_desc regulators[] = {
        },
        regulator_desc_buck(7),
        {
-               .name   = "EN32KHz AP",
+               .name   = "EN32KHz_AP",
                .id     = MAX8997_EN32KHZ_AP,
                .ops    = &max8997_fixedvolt_ops,
                .type   = REGULATOR_VOLTAGE,
                .owner  = THIS_MODULE,
        }, {
-               .name   = "EN32KHz CP",
+               .name   = "EN32KHz_CP",
                .id     = MAX8997_EN32KHZ_CP,
                .ops    = &max8997_fixedvolt_ops,
                .type   = REGULATOR_VOLTAGE,
@@ -940,7 +940,7 @@ static struct regulator_desc regulators[] = {
                .type   = REGULATOR_VOLTAGE,
                .owner   = THIS_MODULE,
        }, {
-               .name   = "CHARGER CV",
+               .name   = "CHARGER_CV",
                .id     = MAX8997_CHARGER_CV,
                .ops    = &max8997_fixedstate_ops,
                .type   = REGULATOR_VOLTAGE,
@@ -952,7 +952,7 @@ static struct regulator_desc regulators[] = {
                .type   = REGULATOR_CURRENT,
                .owner   = THIS_MODULE,
        }, {
-               .name   = "CHARGER TOPOFF",
+               .name   = "CHARGER_TOPOFF",
                .id     = MAX8997_CHARGER_TOPOFF,
                .ops    = &max8997_charger_fixedstate_ops,
                .type   = REGULATOR_CURRENT,
--
1.7.8.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/