Re: [PATCH 08/17] blkcg: shoot down blkio_groups on elevator switch

[Vivek Goyal]

On Mon, Jan 23, 2012 at 09:10:49AM -0800, Tejun Heo wrote:

[..]
> No matter what we do for #2, #1 requires ordering between policy
> selection and configuration.  You're saying that #2, combined with the
> fact that blk-throtl can't be built as module or disabled on runtime,
> allows side-stepping the issue for at least blk-throtl.  That doesn't
> sound like a good idea to me.  People are working on different
> elevators implementing different cgroup strategies.  There is no sane
> way around requiring "choosing of policies" to happen before
> "configuration of chosen policies".

This is not just specific to blk-throttle. If in future throttling policy
is removable like elevator, then it will be fine to reset the throttling
related configuration upon removal of throttling policy. But resetting
throttling configuration without policy going anywhere does not sound good.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/