Re: [PATCH 1/7] leds-lm3530: support pwm input mode

[Linus Walleij]

On Fri, Jan 20, 2012 at 2:46 AM, Kim, Milo <Milo.Kim@xxxxxx> wrote:

> * add 'struct lm3530_pwm_data' in the platform data
>  The pwm data is the platform specific functions which generate the pwm.
>  The pwm data is only valid when brightness is pwm input mode.
>  Functions should be implemented by the pwm driver.
>  pwm_set_intensity() : set duty of pwm.
>  pwm_get_intensity() : get current duty of pwm.
>
> * brightness control by pwm
>  If the control mode is pwm, then brightness is changed by the duty of pwm.
>  So pwm platform function should be called in lm3530_brightness_set().
>
> * do not update brightness register when pwm input mode
>  In pwm input mode, brightness register is not used.
>  If any value is updated in this register, then the led will be off.
>
> * patched based on kernel 3.0.1
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>

Looks nice and clean to me,
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks Milo,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/