Re: [PATCH 1/7] PCI: Make sriov work with hotplug remove

[Linus Torvalds]

On Mon, Jan 23, 2012 at 11:36 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> Maybe we can put VF and PF in bus->devices like:
> VF come first than PF?

Ugh. Ok, so that's a disgusting hack, but it's better than messing up
the generic PCI subsystem. At least it's a disgusting hack in the IOV
code.

I still would prefer to just do the virtual devices right instead. Or
even just make the removal loop inherently robust, rather than have
that insane knowledge of virtual function devices that were done so
horribly wrong.

Or even just *keep* the virtual devices on the list even though the
physical device has been removed - make them independent of the
physical device.

Anything but that "do virtual devices utterly wrong, and then have to
work around it in the generic pci layer because it was done so badly".

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/