Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', ofmtip_hw_submit_io()

From: Christoph Hellwig
Date: Mon Jan 23 2012 - 15:09:38 EST


On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote:
> This device does not support write cache, hence renamed confusing argument
> 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility.

That's not correct, you set it if REQ_FUA is set, which won't ever be
set given how you configure the queue. I.e. it's dead code that can be
removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/