Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb tonetdev_alloc_skb

From: Eric Dumazet
Date: Mon Jan 23 2012 - 16:15:48 EST


Le mardi 24 janvier 2012 Ã 02:11 +0530, Pradeep A. Dalvi a Ãcrit :

> Aah! Is that really needed? Cause from my understanding, priority GFP
> flag __GFP_DMA is anyway negated in __alloc_skb, in a way from all
> sources i.e. netdev_alloc_skb or dev_alloc_skb or even alloc_skb. Am I
> missing something here?

You should read the whole __alloc_skb() function and not only half of
it.

skb itself is allocated in the normal memory pool, (not GFP_DMA), since
it has no hardware requirement for a kernel structure.

But skb->head _is_ allocated with GFP_DMA if driver requested it.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/