Re: [PATCH 1/7] PCI: Make sriov work with hotplug remove

From: Linus Torvalds
Date: Mon Jan 23 2012 - 17:35:50 EST


On Mon, Jan 23, 2012 at 12:48 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> it does not work... get lock up

Hmm. That's consistent with pci_stop_bus_device() just not removing
the device at all from the bus list. Which on the face of it would be
sane, since it's "stop", not "remove".

There's definitely something odd going on about that whole thing - not
just the confusion about "stop" vs "remove". It has that "is_added"
logic too. I have no idea what the logic of that whole thing is, it
really doesn't look sane.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/