Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

[devendra.aaru]

On Sun, Jan 29, 2012 at 5:39 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> We declare 'exact' without initializing it and then do:
>
> [...]
>        if (strlen(p->cru_driver_name))
>                exact = 1;
>
>        if (priority && !exact)
>                return -EINVAL;
>
> [...]
>
> If the first 'if' is not true, then the second will test an
> uninitialized 'exact'.

not needed . as the cru_driver_name will always be present :).
> As far as I can tell, what we want is for 'exact' to be initialized to
> 0 (zero/false).
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> ---
>  crypto/crypto_user.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>  Compile tested only.
>
> diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
> index 16f8693..36a2af7 100644
> --- a/crypto/crypto_user.c
> +++ b/crypto/crypto_user.c
> @@ -304,7 +304,7 @@ static int crypto_del_alg(struct sk_buff *skb, struct nlmsghdr *nlh,
>  static int crypto_add_alg(struct sk_buff *skb, struct nlmsghdr *nlh,
>                          struct nlattr **attrs)
>  {
> -       int exact;
> +       int exact = 0;
>        const char *name;
>        struct crypto_alg *alg;
>        struct crypto_user_alg *p = nlmsg_data(nlh);
> --
> 1.7.8.4
>
>
> --
> Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/