Re: [PATCH 1/2] edac/ppc4xx_edac: Fix compilation

[Josh Boyer]

On Tue, Jan 31, 2012 at 6:37 PM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxx> wrote:
> It seems that nobody is cross-compiling for this arch anymore...
>
> drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_probe':
> drivers/edac/ppc4xx_edac.c:188:12: error: storage class specified for parameter 'ppc4xx_edac_remove'
> ...
> drivers/edac/ppc4xx_edac.c:1068:19: error: 'match' undeclared (first use in this function)
> drivers/edac/ppc4xx_edac.c:1068:19: note: each undeclared identifier is reported only once for each function it appears in
> drivers/edac/ppc4xx_edac.c:1068:36: warning: left-hand operand of comma expression has no effect [-Wunused-value]

Ugh.  The linux-next tree builds ppc44x_defconfig daily, but I don't
have this module enabled there.  I'll get it added.

>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

Acked-by: Josh Boyer <jwboyer@xxxxxxxxx>

> ---
>  drivers/edac/ppc4xx_edac.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
> index 0f06f14..1adaddf 100644
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -184,7 +184,7 @@ struct ppc4xx_ecc_status {
>
>  /* Function Prototypes */
>
> -static int ppc4xx_edac_probe(struct platform_device *device)
> +static int ppc4xx_edac_probe(struct platform_device *device);
>  static int ppc4xx_edac_remove(struct platform_device *device);
>
>  /* Global Variables */
> @@ -1065,7 +1065,7 @@ ppc4xx_edac_mc_init(struct mem_ctl_info *mci,
>
>        mci->mod_name           = PPC4XX_EDAC_MODULE_NAME;
>        mci->mod_ver            = PPC4XX_EDAC_MODULE_REVISION;
> -       mci->ctl_name           = match->compatible,
> +       mci->ctl_name           = ppc4xx_edac_match->compatible,
>        mci->dev_name           = np->full_name;
>
>        /* Initialize callbacks */
> --
> 1.7.8
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/