Re: [PATCH 5/7] ftrace, perf: Add support to use functiontracepoint in perf

[Steven Rostedt]

On Thu, 2012-02-02 at 19:14 +0100, Frederic Weisbecker wrote:

> All the above from perf_ftrace_function_call() to here should perhaps
> go to trace_function.c.

Please no. This is a perf specific call into the function tracer.
Unless it is rewritten to be a completely generic function. As with the
normal rational on "generic" vs "specific" in the kernel. When there's
only one user, then keep it "specific". When we get two or more users,
then it can be converted to be generic.

Please do not put this into trace_function.c, as the only user of it is
here.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/