Re: [PATCH V1 1/2] mfd: tps65910: use regmap for device registeraccess.

[Laxman Dewangan]

On Thursday 09 February 2012 05:25 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Thu, Feb 09, 2012 at 10:33:01AM +0530, Laxman Dewangan wrote:
> > On Wednesday 08 February 2012 07:28 PM, Mark Brown wrote:
> > > But that's just raw_write(), there's no benefit to the additional API
> > > call.
> > raw_write supported for the volatile register only.
>
> Note that there's a very important difference between the bulk and raw
> versions of the API which you're not taking into account: the bulk
> version takes care of endianness differences between the device and the
> host.  This would mean that for send we'd need to rewrite the input
> array which means we have to take a copy of the data as we probably
> shouldn't be changing the input data.
Yes, I am taking care of this. Probably my code will explain this :)

I have my patch ready. Let me send this..

> Indeed, looking at the drivers in mainline I can't actually see any of
> them which do block writes.
I am working on mfd/tps65910.c and function is:
static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
                                   int bytes, void *src)

All your feedback will help me to improve my next two mfd/pmic drivers 
which I am planning to upstream...


> * Unknown Key
> * 0x6E30FDDD

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/