Re: [PATCH 1/2] perf-tool: Don't process samples with no validmachine object

[Joerg Roedel]

On Thu, Feb 09, 2012 at 02:34:41PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 09, 2012 at 05:07:38PM +0100, Joerg Roedel escreveu:
> > -		if (event->header.type == PERF_RECORD_SAMPLE) {
> > +		if (event->header.type == PERF_RECORD_SAMPLE && machine != NULL) {
> 
> Shouldn't we warn the user, even if just once, on the status (last line
> on the screen) line?

Probably yes, what would be a good message? I guess something like

	"no machine object for sample"

is not helpful to the user. Maybe something like

	"Unresolvable sample(s) recorded"?

Or something completly different?


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/