Re: Re: [PATCH v5 5/5] Extcon: adc-jack driver to support 3.5 pior simliar devices

[Mark Brown]

On Tue, Feb 14, 2012 at 07:00:48AM +0000, MyungJoo Ham wrote:
> Mark Brown wrote:

> > No, that's not what I'm suggesting - what I'm suggesting is that rather
> > than having a callback for implementing the ADC read functionality this
> > should work as an in-kernel IIO driver so it'll just automatically work
> > with any ADC without needing code to hook things up.  Unless I've not
> > understood your comment fully.

> Ok. Do you mean that we should give struct iio_dev * and struct
> iio_chan_spec * instead of a callback?  I thought there was no
> standard framework for ADC (the reason why this is a simple callback);
> however, may I regard iio/adc as the standard for ADC? (I see some ADC
> device drivers in HWMON)

Yes, the idea is that IIO becomes the standard way of using general
purpose ADCs like this in the kernel rather than having lots of similar
custom APIs floating around with callbacks as we do now.

> Do I need to make this driver as an iio device driver in order to do this? I guess including iio.h would be enough anyway.

I'd not expect so, I'd expect it's just a user of IIO.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/