Re: [PATCH 2/2] Netfilter: xt_LOG: Add timestamp support

[Richard Weinberger]

Am 15.02.2012 18:16, schrieb Jan Engelhardt:
> On Wednesday 2012-02-15 15:07, Richard Weinberger wrote:
> > > > +		struct timespec tv;
> > > > +		unsigned int msec;
> > > > +
> > > > +		getnstimeofday(&tv);
> > > > +		msec = tv.tv_nsec / NSEC_PER_MSEC;
> > > > +		sb_add(m, "TIMESTAMP=%li.%03li ", tv.tv_sec, msec);
> > >
> > > Since you want to use this temp variable "unsigned int msec" (I have no
> > > idea why...), you must change printf format accordingly : %03u instead
> > > of %03li
> >
> > *grml*.
> > I'll remove the temp variable and use %03u.
>
> Why not just print the nsecs directly (with %09 of course)?

I don't think that a nanosecond resolution is useful.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/