Re: [PATCH v2 04/11] firewire-sbp-target: Add sbp_base.h header

[Chris Boot]

On 15/02/2012 19:15, Stefan Richter wrote:
> On Feb 15 Chris Boot wrote:
> > --- /dev/null
> > +++ b/drivers/target/sbp/sbp_base.h
> > @@ -0,0 +1,204 @@
> [...]
> > +struct sbp2_pointer {
> > +	__be32 high;
> > +	__be32 low;
> > +};
> [...]
> > +struct sbp_tport {
> > +	/* Target Unit Identifier (EUI-64) */
> > +	u64 guid;
> > +	/* Target port name */
> > +	char tport_name[SBP_NAMELEN];
> > +	/* Returned by sbp_make_tport() */
> > +	struct se_wwn tport_wwn;
> > +
> > +	struct sbp_tpg *tpg;
> > +
> > +	/* FireWire unit directory */
> > +	struct fw_descriptor unit_directory;
> > +
> > +	/* SBP Management Agent */
> > +	struct sbp_management_agent *mgt_agt;
> > +
> > +	/* Parameters */
> > +	int enable;
> > +	s32 directory_id;
> > +	int mgt_orb_timeout;
> > +	int max_reconnect_timeout;
> > +	int max_logins_per_lun;
> > +};
> > +
> > +extern struct target_fabric_configfs *sbp_fabric_configfs;
> > +extern const struct fw_address_region sbp_register_region;
> > +extern struct workqueue_struct *sbp_workqueue;
> [...]
>
> Generally, any source file (.c or .h) is meant to be self-contained WRT
> type definitions etc., meaning that they should have all required
> #include's in themselves rather than rely on indirect includes.
>
> So here you should include the headers which define __be32, u64, struct
> se_wwn, struct workqueue and so on.

Thanks. I'll work on fixing this.

Cheers,
Chris

--
Chris Boot
bootc@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/