Re: [PATCH V2 1/3] bluetooth: Add logging functions bt_info andbt_err

From: Marcel Holtmann
Date: Fri Feb 17 2012 - 03:38:01 EST


Hi Joe,

> Use specific logging functions instead of a generic
> bt_printk function can save some text.
>
> Remove now unused bt_printk function.
> Add compatibility BT_INFO and BT_ERR macros.
>
> (compiled x86 and defconfig with bluetooth and all bluetooth drivers)
>
> $ size net/bluetooth/built-in.o*
> text data bss dec hex filename
> 381662 20072 100416 502150 7a986 net/bluetooth/built-in.o.allyesconfig.new
> 382463 20072 100400 502935 7ac97 net/bluetooth/built-in.o.allyesconfig.old
> 126635 1388 132 128155 1f49b net/bluetooth/built-in.o.defconfig.new
> 127175 1388 132 128695 1f6b7 net/bluetooth/built-in.o.defconfig.old
>
> $ size drivers/bluetooth/built-in.o*
> 127575 8976 29476 166027 2888b drivers/bluetooth/built-in.o.allyesconfig.new
> 129512 8976 29516 168004 29044 drivers/bluetooth/built-in.o.allyesconfig.old
> 52998 3292 156 56446 dc7e drivers/bluetooth/built-in.o.defconfig.new
> 54358 3292 156 57806 e1ce drivers/bluetooth/built-in.o.defconfig.old
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> include/net/bluetooth/bluetooth.h | 14 ++++++++------
> net/bluetooth/lib.c | 27 ++++++++++++++++++++++++---
> 2 files changed, 32 insertions(+), 9 deletions(-)

lets try to get at least this patch merged. I hope we don't have too
many conflicts.

Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/