Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin

[Danny Kukawka]

On Freitag, 17. Februar 2012, Mike Frysinger wrote:
> On Thu, Feb 16, 2012 at 12:09, Danny Kukawka wrote:
> > + Â Â Â Â Â Â Â Â Â Â Â netdev_warn(ndev, "Setting Ethernet MAC to a
> > random one\n"); + Â Â Â Â Â Â Â Â Â Â Â eth_hw_addr_random(ndev);
>
> would it make sense to have the core dump the warning ?

Maybe. Many drivers already print information about setting a random mac 
address to a netdevice. Some with printk, some via 
netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum 
methods. I could unify this, in a next step with a netdev_info in 
eth_hw_addr_random(), if it's okay for David. 

Danny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/