Re: [linux-pm] [PATCH] PM / QoS: unconditionally build the feature

From: Rafael J. Wysocki
Date: Fri Feb 17 2012 - 15:44:35 EST


On Friday, February 17, 2012, Pavel Machek wrote:
> On Mon 2012-02-13 16:41:10, Rafael J. Wysocki wrote:
> > On Monday, February 13, 2012, Jean Pihet wrote:
> > > The PM QoS feature depends on CONFIG_PM which depends on
> > > PM_SLEEP || PM_RUNTIME. This breaks CPU C-states with kernels
> > > not having these CONFIGs.
> > >
> > > This patch allows the feature in all cases.
> > >
> > > Signed-off-by: Jean Pihet <j-pihet@xxxxxx>
> > > Reported-by: Venkatesh Pallipadi <venki@xxxxxxxxxx>
> > > Cc: Rafael J. Wysocki <rjw@xxxxxxx>
> > > Cc: Mark Gross <markgross@xxxxxxxxxxx>
> >
> > Applied, but I modified the changelog (please have a look at the
> > linux-pm/pm-qos branch for details).
>
> Is it good idea? For servers, power management / QoS is not
> neccessary...

Yes, it is. They surely use CPUidle.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/