re: w1: Fix w1_bq27000

From: Dan Carpenter
Date: Sat Feb 18 2012 - 15:52:43 EST


Hello NeilBrown,

This is a semi-automatic email about new static checker warnings.

The patch 9f3519d2ed26: "w1: Fix w1_bq27000" from Feb 15, 2012, leads
to the following Smatch complaint:

drivers/w1/slaves/w1_bq27000.c:48 w1_bq27000_read()
warn: variable dereferenced before check 'dev' (see line 46)

drivers/w1/slaves/w1_bq27000.c
45 u8 val;
46 struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev);
^^^^^^^^^^^
New dereference.

47
48 if (!dev)
^^^
Old check.

49 return 0;
50

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/