Re: [PATCH] mm: add config NUMA stub to all architectures

[Randy Dunlap]

On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote:
> On Fri, Feb 17, 2012 at 21:30, Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx>  wrote:
> > On Fri, 17 Feb 2012 16:08:15 +0400
> > Konstantin Khlebnikov<khlebnikov@xxxxxxxxxx>  wrote:
> >
> > > Config NUMA must be defined for all architectures,
> > > otherwise IS_ENABLED(CONFIG_NUMA) does not work.
> > > Some arch-specific Kconfig already has this stub.
> > > This patch adds it to all remaining.
> >
> > It would be better to teach IS_ENABLED() to handle this situation.  I
> > don't think there's a way of doing this with cpp :(
> >
> > This limitation makes IS_ENABLED pretty dangerous, doesn't it?  It
> > makes it very easy to introduce build breakage with unexpected Kconfig
> > combinations.
>
> Indeed. Recently I discovered IS_ENABLED() and started recommending it
> to people for new code. But now I've seen the CONFIG_NUMA breakage,
> I no longer think this is a good recommendation.


adding Michal & linux-kbuild to cc: list.

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/