Re: [RFC PATCH 0/4] Gang scheduling in CFS

[Peter Zijlstra]

On Mon, 2012-02-20 at 13:38 +0530, Nikunj A Dadhania wrote:
> +#ifdef CONFIG_PARAVIRT_FLUSH_TLB
> +               while (!cpumask_empty(to_cpumask(f->flush_cpumask)) && --loop)
> +                       cpu_relax();
> +               if (!loop && !cpumask_empty(to_cpumask(f->flush_cpumask)))
> +                       halt();


That's just vile, you don't need to wait for it, all you need to make
sure is that when that vcpu wakes up it does the flush.

But yeah, the results are a good hint that you're on the right track.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/