Re: Re: [PATCH v2 3/3] i387: support lazy restore of FPU state

[Jongman Heo]

> Sender : Linus Torvalds<torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date : 2012-02-21 11:18 (GMT+09:00)
> Title : Re: [PATCH v2 3/3] i387: support lazy restore of FPU state
> 
> On Mon, Feb 20, 2012 at 6:10 PM, Linus Torvalds
> wrote:
> >
> > The attached trivial patch fixes it, I bet.
> 
> Actually, it doesn't fix it on x86-32, because we actually have an
> #ifdef CONFIG_X86_64 around the "current_task" definition due to
> pointless differences in how we do that on x86-64 and x86-32.
> 
> So much for the "common" part of "arch/x86/kernel/cpu/common.c"
> 
> > Although I do wonder if we should just make kernel_fpu_begin() be a
> > real function instead of inlining it. I'm not sure it makes sense to
> > inline that thing, and it might be better to export that one instead.
> 
> I do think that would be better in the long run, but for now here's an
> updated "trivial" patch to fix it.
> 
> I want the fpu_owner_task to be declared next to the cache-hot
> task-switching stuff, and since they are different on 32-bit and
> 64-bit (for no really good reason), that gets duplicated too. Sad.
> 
>                         Linus
> 
>                       Linus

Yeah, this patch fixes my x86-32 build.

Thanks,
Jongman Heo.N떑꿩ěr¸›y鉉싕b˛XФ푤vŘ^–)頻{.nÇ+돴ĽŠ{ą묎çzX㎍썳變}Š옽Ć zÚ&j:+v돣žŤ묎çzZ+€Ę+zf＂ˇhš닱~넮녬i˙鎬zšŽwⅱ¸?솳鈺Ú&˘)刪f뷌^j푹y§m끷@AŤa뛴˙0띠hŽĺ’i