RE: [PATCH] checkpatch: Add some --strict coding style checks

From: Johannes Berg
Date: Wed Feb 22 2012 - 04:46:31 EST


On Wed, 2012-02-22 at 09:35 +0000, David Laight wrote:
> > if (!(func_a(x) &&
> > func_b(y)))
> > baz();
>
> Gah - that is horrid for the 'preferred style'.
> A quick glance at the code puts both the func_b()
> and baz() calls as inside the if.

You forgot to read/quote the rest of Allan's email:

> Assuming my stupid mailer will screw up the indentation above, the 'a'
> in addr in the first example is meant to be immediately below the 'n'
> in nr, and the two 'f's in func_* are meant to be vertically lined up
> in the second example.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/