Re: [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc_fdtable

[H. Peter Anvin]

On 02/23/2012 06:40 AM, Bobby Powers wrote:
> On Wed, Feb 22, 2012 at 5:18 AM, David Howells<dhowells@xxxxxxxxxx>  wrote:
> > Bobby Powers<bobbypowers@xxxxxxxxx>  wrote:
> >
> > > alloc_fdtable allocates space for the open_fds and close_on_exec
> > > bitfields together, as 2 * nr / BITS_PER_BYTE.  close_on_exec needs to
> > > point to open_fds + nr / BITS_PER_BYTE, not open_fds + nr /
> > > BITS_PER_LONG, as introducted in 1fd36adc: Replace the fd_sets in
> > > struct fdtable with an array of unsigned longs.
> > >
> > > Signed-off-by: Bobby Powers<bobbypowers@xxxxxxxxx>
> >
> > Yes, you're right.  At one point I changed data to be an unsigned long *.
> >
> > Acked-by: David Howells<dhowells@xxxxxxxxxx>
>
> Thanks, its nice to have confirmation - I'm still pretty new at this.
> Can this get pulled onto tip/x86/x32?  Desktop applications like
> firefox and chrome don't work reliably without it.

tip:core/types (and the updated core/types needs to be merged into 
x86/x32) but yes.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/