Re: [PATCH 4/7] PCI: Retry on type IORESOURCE_IO allocation.

From: Jesse Barnes
Date: Thu Feb 23 2012 - 14:54:53 EST


On Fri, 10 Feb 2012 15:33:49 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> During reenabling pci reallocating for pci bridge by clean the small size in
> bridge and assign with requested + optional size for first several try,
> Ram mention could have problem with one case
> https://bugzilla.kernel.org/show_bug.cgi?id=15960
>
> After checking the booting log in
> https://lkml.org/lkml/2010/4/19/44
> [regression, bisected] Xonar DX invalid PCI I/O range since 977d17bb174
>
> We should not stop too early for io ports.
> Apr 19 10:19:38 [kernel] pci 0000:04:00.0: BAR 7: can't assign io (size 0x4000)
> Apr 19 10:19:38 [kernel] pci 0000:05:01.0: BAR 8: assigned [mem 0x80400000-0x805fffff]
> Apr 19 10:19:38 [kernel] pci 0000:05:01.0: BAR 7: can't assign io (size 0x2000)
> Apr 19 10:19:38 [kernel] pci 0000:05:02.0: BAR 7: can't assign io (size 0x1000)
> Apr 19 10:19:38 [kernel] pci 0000:05:03.0: BAR 7: can't assign io (size 0x1000)
> Apr 19 10:19:38 [kernel] pci 0000:08:00.0: BAR 7: can't assign io (size 0x1000)
> Apr 19 10:19:38 [kernel] pci 0000:09:04.0: BAR 0: can't assign io (size 0x100)
> and clear 00:1c.0 to retry again.
>
> The patch remove the IORESOUCE_IO checking, and try one more time.
> and we will have chance to get allocation for 00:1c.0 io port range because
> from 0x4000 to 0x8000 could be used.

This one no longer applies, can you send an update against my
linux-next branch later today or tomorrow when I've pushed?

I'm still a little worried about the automatic re-alloction stuff, but
since it's under a new config option it ought to be ok. See my other
mails for comments there.

--
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature