Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

[Frederic Weisbecker]

On Thu, Mar 08, 2012 at 08:29:01AM +0100, Ingo Molnar wrote:
> 
> * Arun Sharma <asharma@xxxxxx> wrote:
> 
> > This patch series refactors existing code a bit and adds sort by 
> > inclusive time (time spent in the function + callees).
> > 
> > Sample command lines:
> > 
> > # perf record -ag -- sleep 1
> > # perf report -g graph,0.5,callee -n -s inclusive
> 
> So I tried this out with:
> 
>   $ taskset 1 perf record -g git gc
> 
> and got entries above 100% (in the TUI):
> 
>   $ perf report -g graph,0.5,callee -n -s inclusive
> 
>  +  321.11%        5628  [.] 0x392b609269
>  +  142.27%        3774  [.] create_delta
>  +  78.86%        1248  [.] lookup_object
>  +  40.54%        1348  [k] system_call_fastpath
>  [...]
> 
> Is that expected?

I think this happens because of this:

-               hists->stats.total_period += h->period;                                                                                
+               if (!h->inclusive)                                                                                                     
+                       hists->stats.total_period += h->period;

Which I'm not sure why it is needed btw.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/