Re: [PATCH] spi: Trivial warning fix

[Grant Likely]

On Mon, 27 Feb 2012 19:29:05 +0530, Shubhrajyoti D <shubhrajyoti@xxxxxx> wrote:
> The loop count i traverses for ntrans which is unsigned
> so make the loop count i also unsigned.
> 
> Fix the below warning
> In file included from drivers/spi/spi-omap2-mcspi.c:38:
> include/linux/spi/spi.h: In function 'spi_message_alloc':
> include/linux/spi/spi.h:556: warning: comparison between signed and unsigned integer expressions
> 
> Cc: Vitaly Wool <vwool@xxxxxxxxxxxxx>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx>
> ---

Applied, thanks.

g.

> Untested !
> 
>  include/linux/spi/spi.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
> index 176fce9..6ae4993 100644
> --- a/include/linux/spi/spi.h
> +++ b/include/linux/spi/spi.h
> @@ -549,7 +549,7 @@ static inline struct spi_message *spi_message_alloc(unsigned ntrans, gfp_t flags
>  			+ ntrans * sizeof(struct spi_transfer),
>  			flags);
>  	if (m) {
> -		int i;
> +		unsigned i;
>  		struct spi_transfer *t = (struct spi_transfer *)(m + 1);
>  
>  		INIT_LIST_HEAD(&m->transfers);
> -- 
> 1.7.0.4
> 
> 
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/