Re: [patch] vt: NULL dereference in vt_do_kdsk_ioctl()

[Alan Cox]

On Sat, 10 Mar 2012 11:59:23 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> We forgot to set the "key_map" variable here, so it's still NULL.  This
> was introduced recently in 079c9534a9 "vt:tackle kbd_table".
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index 70d0593..86dd1e3 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -1863,6 +1863,7 @@ int vt_do_kdsk_ioctl(int cmd, struct kbentry __user *user_kbe, int perm,
>  				return -EPERM;
>  			}
>  			key_maps[s] = new_map;
> +			key_map = new_map;
>  			key_map[0] = U(K_ALLOCATED);
>  			for (j = 1; j < NR_KEYS; j++)
>  				key_map[j] = U(K_HOLE);

Eep I thought I got all of those. Well noted

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/