Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irqand free_irq are compatible

[Julia Lawall]

On Sun, 11 Mar 2012, Chas Williams (CONTRACTOR) wrote:

> i am pretty sure that request_irq() shouldnt be changed but rather
> free_irq() changed.  the last argument of request_irq() is passed to the
> interrupt routine (ent_int in this case).  if you change that you need
> to update the interrupt routine.  fixing free_irq would be easier.

OK, thanks for the feedback.  I will fix it up.

julia

> In message <1331494587-12196-6-git-send-email-Julia.Lawall@xxxxxxx>,Julia Lawall writes:
> > Convert call to request_irq so that the last argument is the same as the
> > second argument of the subsequent call to free_irq.  Without this
> > property, free_irq does nothing.
> >
> > I have chosen to keep the call to free_irq as is, because its second
> > argument is more like its first argument.
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/