Re: [PATCH v2 3/3] mac80211: improve PID rate control mechanism byavoiding rate oscillation problem

[Julian Calaby]

Hi Wei,

Again, a couple of minor comments.

On Mon, Mar 12, 2012 at 12:14, wei <yinwei168@xxxxxxxxx> wrote:
> From Wei YIN <Wei.Yin@xxxxxxxxxxxx>
> Improve PID rate control mechanism by avoiding rate oscillation problem
>
> Signed-off-by: Wei YIN <Wei.Yin@xxxxxxxxxxxx>
> ---
> kernel 3.3.0
> net/mac80211/rc80211_pid_debugfs.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 65 insertions(+), 6 deletions(-)
>
> --- wireless-testing_orig/net/mac80211/rc80211_pid_debugfs.c    2012-02-17 13:59:53.487182968 +1000
> +++ wireless-testing/net/mac80211/rc80211_pid_debugfs.c 2012-03-08 14:45:38.727184486 +1000
> @@ -1,5 +1,6 @@
>  /*
>  * Copyright 2007, Mattias Nissler <mattias.nissler@xxxxxx>
> + * Copyright 2012, Wei Yin, National ICT Australia <Wei.Yin@xxxxxxxxxxxx>
>  *
>  * This program is free software; you can redistribute it and/or modify
>  * it under the terms of the GNU General Public License version 2 as
> @@ -13,12 +14,72 @@
>  #include <linux/types.h>
>  #include <linux/skbuff.h>
>  #include <linux/slab.h>
> -#include <linux/export.h>

This change should go in a separate patch.

>  #include <net/mac80211.h>
>  #include "rate.h"
>
>  #include "rc80211_pid.h"
> +#include <linux/debugfs.h>
> +#include <linux/ieee80211.h>
> +#include <linux/slab.h>
> +#include <linux/export.h>

Different types of includes should be grouped together, the #include
<linux/*> lines should go with their fellows at the top.

Overall, this is significantly improved over your first patch. Well Done.

Does anyone else have any comments about this?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/