Re: [PATCH] tile: remove a non-existing header

[Chris Metcalf]

On 3/12/2012 10:18 AM, Mauro Carvalho Chehab wrote:
> While testing some API changes at the EDAC core, I've tested the EDAC
> drivers compilation on all supported architectures, including Tilera.
>
> I noticed that Tilera upstream code has issues: it doesn't compile with
> kernel 3.2:
>
> In file included from include/linux/linkage.h:5,
>                  from include/linux/kernel.h:13,
>                  from include/linux/sched.h:55,
>                  from arch/tile/kernel/asm-offsets.c:19:
> /home/mchehab/redhat/trees/work/new_edac/arch/tile/include/asm/linkage.h:18:22: error: feedback.h: No such file or directory
> make[1]: *** [arch/tile/kernel/asm-offsets.s] Error 1
>
> Without it, it is not possible to compile anything on this archictecture
> using this default configuration:
> 	./arch/tile/configs/tilegx_defconfig
>
> Cc: stable@xxxxxxxxxx
> Signed-of-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

Thank you, but nack.  The header is provided in the latest gcc tip code. 
Sorry for the API thrash!  It's certainly OK to comment it out for the time
being; it just provides some assembly macros for specifying feedback-guided
optimization.

> Btw, the ./arch/tile/configs/tilepro_defconfig doesn't compile even
> with this fix. It fails at arch/tile/include/asm/atomic_64.h because
> atomic64_t is never defined, but it is used there and on other places.

I'll take a look at this; I've been focusing primarily on the tilegx
architecture recently and something may have bitrotted in the tilepro
support.  Thanks for the pointer.

> Also, while the edac_tile driver seems to be for both Tile GX and Tilepro
> sub-archs, it is not included on tilegx_defconfig. It would make sense
> to add it there, in order to make easier for people to test/use the
> EDAC drivers.

That's probably a good idea; we do enable it by default in our actual
shipping configuration.  I've heard mixed things about the utility of
including "config" files in the kernel, so I haven't been bothering to
update them, but it's probably worth a refresh at this point.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/