Re: [PATCH] scripts: refactor remove structure forward declarations

[Stephen Boyd]

On 03/12/12 01:20, Yang Bai wrote:
> Since now it has some problems when generate TAGS,
> refactor this code. Now it will not show the error
> message and will remove declarations using emacs etags.
>
> Signed-off-by: Yang Bai <hamo.by@xxxxxxxxx>

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

> ---
>  scripts/tags.sh |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 833813a..2b377fc 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -166,9 +166,6 @@ exuberant()
>  	all_defconfigs | xargs -r $1 -a                         \
>  	--langdef=dotconfig --language-force=dotconfig          \
>  	--regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'
> -
> -	# Remove structure forward declarations.
> -	LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' tags
>  }
>  
>  emacs()
> @@ -233,6 +230,7 @@ if [ "${ARCH}" = "um" ]; then
>  	fi
>  fi
>  
> +remove_structs=
>  case "$1" in
>  	"cscope")
>  		docscope
> @@ -245,10 +243,17 @@ case "$1" in
>  	"tags")
>  		rm -f tags
>  		xtags ctags
> +		remove_structs=y
>  		;;
>  
>  	"TAGS")
>  		rm -f TAGS
>  		xtags etags
> +		remove_structs=y
>  		;;
>  esac
> +
> +# Remove structure forward declarations.
> +if [ -n $remove_structs ]; then
> +    LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
> +fi


-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/