Re: [PATCH 0/6] gpio/omap: Some more driver cleanup and fixes

[Grant Likely]

On Thu, 23 Feb 2012 17:56:33 +0530, "Shilimkar, Santosh" <santosh.shilimkar@xxxxxx> wrote:
> On Thu, Feb 23, 2012 at 5:40 PM, Tarun Kanti DebBarma
> <tarun.kanti@xxxxxx> wrote:
> > The cleanup is mostly getting rid of redundant fields in struct gpio_bank{}
> > as we already have them as part of bank->context now. Also, remove un-used
> > variable from gpio_irq_handler.
> >
> > The fix include correction of _set_gpio_irqenable() implementation and fix
> > type mismatch of gpio trigger parameter.
> >
> > It is baselined on top of Kevin's following series:
> > gpio/omap: cleanup and runtime PM conversion for v3.4
> > git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/gpio/runtime-pm-cleanup
> >
> > I have applied Benoit's GPIO patches in following series on top of Kevin's
> > before applying my changes.
> > gpio/omap: Cleanup and adaptation to Device Tree
> > git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.4/dt_gpio
> >
> > Series is available here for reference:
> > git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev for_3.4/gpio_further_cleanup_fixes
> >
> > Power Test: Off-mode and Retention on OMAP3430 (Suspend and Idle paths).
> > Functional Test: OMAP2430, OMAP3430SDP, ZOOM3, OMAP4430, OMAP4-BLAZE
> >
> > Tarun Kanti DebBarma (6):
> > Â gpio/omap: remove saved_fallingdetect, saved_risingdetect fields
> > Â gpio/omap: remove saved_wakeup field from struct gpio_bank
> > Â gpio/omap: remove suspend_wakeup field from struct gpio_bank
> > Â gpio/omap: get rid of retrigger variable in gpio_irq_handler
> > Â gpio/omap: fix trigger type to unsigned
> > Â gpio/omap: fix _set_gpio_irqenable implementation
> >
> > Â drivers/gpio/gpio-omap.c | Â  56 +++++++++++++++++++--------------------------
> > Â 1 files changed, 24 insertions(+), 32 deletions(-)
> >
> Nice clean-up series. I have gone through this series one more time
> Thanks for updating change-logs. I noticed you dropped the edge triggered
> irq wakeup fix....I see on the list now.... Kevin has fixed that already.
> 
> Series looks good to me. You can add:
> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>

What's the status of this series?  Should I be expecting a v2?  Or am I supposed
to pick up this one? (a pull req would make things easier for me)

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/