Re: [PATCH] blk-cgroup: Call cgroup_path only under cgroup lock

[Tejun Heo]

On Mon, Mar 12, 2012 at 08:06:53PM +0200, Sasha Levin wrote:
> On Mon, Mar 12, 2012 at 8:04 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > Hello, Sasha.
> >
> > On Mon, Mar 12, 2012 at 04:01:18PM -0400, Sasha Levin wrote:
> >> Since we can't keep rcu read lock during blkg_alloc(), we currently
> >> call cgroup_path() without any locks at all.
> >>
> >> This patch adds cgroup locking before calling cgroup_path.
> >>
> >> This also fixes a lockdep warning on boot.
> >>
> >> Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx>
> >
> > Which branch is this against?  There's already pending stat update
> > patch from Vivek which fix this problem along with the percpu
> > allocation problem.
> >
> > Thanks.
> 
> I've fixed it for linux-next.

Jens, the pending stats patchset should fix this problem too.  Can you
please put them on top of other blkcg updates?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/