Re: [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs

From: simon
Date: Mon Mar 12 2012 - 14:19:27 EST


> On Mon, Mar 12, 2012 at 02:04:14PM -0400, simon@xxxxxxxxxxxxx wrote:
>
>> At the moment you'd just drive the LEDs simply, ie:
>> $ echo 31 > /sys/bus/hid/devices/.../leds
>
> Shouldn't this be using the LED subsystem the kernel already has?
>

The LED subsystem appears to be aim at controller chips (ie. lp3944) which
are connected to a bus (I2C) in a generalised form. I guess people might
be doing 'blinken light' type systems.

The LEDs on the G27 are very much more specific, mounted on the yoke of
the gaming wheel.

Would this require the use/complexity of the LED subsystem?
Simon


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/