RE: [PATCH 1/2] gpio/davinci: fix oops on unbanked gpio irq request

[Nori, Sekhar]

Hi Grant,

On Mon, Mar 12, 2012 at 23:21:35, Grant Likely wrote:
> On Sun, 11 Mar 2012 18:16:11 +0530, Sekhar Nori <nsekhar@xxxxxx> wrote:
> > Unbanked GPIO irq setup code was overwriting chip_data leading
> > to the following oops on request_irq()
> > 
> > Unable to handle kernel paging request at virtual address febfffff
> [...]
> > Fix the issue.
> 
> Applied, but for next time "Fix the issue" isn't the most helpful commit text.
> Please describe *how* you fixed the issue so that future commit readers have
> more clues as to what this patch is doing.

Thanks for the feedback and noted for future. If it's not too much trouble, 
can you change the last line in commit message to:

Fix the issue by making unbanked GPIO code not overwrite chip_data because 
generic irq chip code uses it for its data structures. Instead use 
handler_data to pass around GPIO controller information.

Regards,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/