Re: [PATCH] PM / devfreq: add relation of recommended frequency.

From: Rafael J. Wysocki
Date: Mon Mar 12 2012 - 19:42:57 EST


On Monday, March 12, 2012, MyungJoo Ham wrote:
> 2012/3/11 Rafael J. Wysocki <rjw@xxxxxxx>:
> > On Wednesday, March 07, 2012, MyungJoo Ham wrote:
> >> The semantics of "target frequency" given to devfreq driver from
> >> devfreq framework has always been interpretted as "at least" or GLB
> >> (greatest lower bound). However, the framework might want the
> >> device driver to limit its max frequency (LUB: least upper bound),
> >> especially if it is given by thermal framework (it's too hot).
> >>
> >> Thus, the target fuction should have another parameter to express
> >> whether the framework wants GLB or LUB. And, the additional parameter,
> >> "u32 options", does it.
> >>
> >> With the update, devfreq_recommended_opp() is also updated.
> >>
> >> Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> >
> > This one looks good.
> >
> > Do you want me to take it as a patch, or to pull it from your tree?
> >
> > Rafael
>
> Hello Rafael,
>
>
> Please pull it from the tree
> (http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/devfreq-for-next)
> as the change log has been corrected.
>
> git://git.infradead.org/users/kmpark/linux-samsung devfreq-for-next

I'm not happy with the "PM / devfreq: add PM QoS support" commit, however.

I believe I explained the reason why in a separate message sent a couple of
days ago.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/