Re: [PATCH v5 4.5/7] mm: optimize isolate_lru_pages()

[KAMEZAWA Hiroyuki]

On Sun, 11 Mar 2012 18:36:16 +0400
Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx> wrote:

> This patch moves lru checks from __isolate_lru_page() to its callers.
> 
> They aren't required on non-lumpy reclaim: all pages are came from right lru.
> Pages isolation on memory compaction should skip only unevictable pages.
> Thus we need to check page lru only on pages isolation for lumpy-reclaim.
> 
> Plus this patch kills mem_cgroup_lru_del() and uses mem_cgroup_lru_del_list()
> instead, because now we already have lru list index.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
> 
> add/remove: 0/1 grow/shrink: 2/1 up/down: 101/-164 (-63)
> function                                     old     new   delta
> static.isolate_lru_pages                    1018    1103     +85
> compact_zone                                2230    2246     +16
> mem_cgroup_lru_del                            65       -     -65
> __isolate_lru_page                           287     188     -99


Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/