Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

[KyongHo Cho]

On Tue, Mar 13, 2012 at 12:01 AM, Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> On Fri, Mar 09, 2012 at 09:15:24PM +0900, Cho KyongHo wrote:
>> +/* We does not consider super section mapping (16MB) */
>> +struct iommu_client {
>> +     struct list_head node;
>> +     struct device *dev;
>> +};
>> +
>> +struct exynos_iommu_domain {
>> +     struct list_head clients; /* list of iommu_client */
>> +     unsigned long *pgtable; /* lv1 page table, 16KB */
>> +     short *lv2entcnt; /* free lv2 entry counter for each section */
>> +     spinlock_t lock; /* lock for this structure and attached iommu_client */
>> +     spinlock_t pgtablelock; /* lock for modifying page table @ pgtable */
>> +};
>> +
>> +struct sysmmu_drvdata {
>> +     struct device *sysmmu;
>> +     char *dbgname;
>> +     int nsfrs;
>> +     void __iomem **sfrbases;
>> +     struct clk *clk[2];
>> +     int activations;
>> +     rwlock_t lock;
>> +     struct iommu_domain *domain;
>> +     sysmmu_fault_handler_t fault_handler;
>> +     unsigned long pgtable;
>> +     struct iommu_client client;
>> +};
>
> Is there any reason why 'struct iommu_client' is a seperate data
> structure? Otherwise it can be merged with 'truct sysmmu_drvdata'.
>

There is no reason to separate it.
It is not cleanly refactored since patch version 10.

>> +static void exynos_iommu_domain_destroy(struct iommu_domain *domain)
>> +{
>> +     struct exynos_iommu_domain *priv = domain->priv;
>> +     struct list_head *pos, *n;
>> +     unsigned long flags;
>> +     int i;
>> +
>> +     WARN_ON(!list_empty(&priv->clients));
>> +
>> +     spin_lock_irqsave(&priv->lock, flags);
>> +
>> +     list_for_each_safe(pos, n, &priv->clients) {
>> +             struct iommu_client *client;
>> +
>> +             client = list_entry(pos, struct iommu_client, node);
>> +             exynos_sysmmu_disable(client->dev);
>> +             kfree(client);
>> +     }
>
> Why this kfree here? Aren't all iommu_clients just a part of another
> data-structre?

It is absolutely my fault. It must be removed.
I have forgot to care about updating iommu_domain_destroy()
when modifying exynos_iommu_attach/detach_device().

Thank you.

The problems will be soon fixed and I will post next patch tomorrow.

Cho KyongHo/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/